Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmpz: Implement nmpz bot #954

Merged
merged 4 commits into from
Oct 22, 2024
Merged

nmpz: Implement nmpz bot #954

merged 4 commits into from
Oct 22, 2024

Conversation

sh-mug
Copy link
Member

@sh-mug sh-mug commented Oct 22, 2024

image

@sh-mug sh-mug self-assigned this Oct 22, 2024
hakatashi
hakatashi requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@hakatashi hakatashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SHOULD] CODEOWNERS ファイルも編集しておいてください

nmpz/index.ts Outdated Show resolved Hide resolved
nmpz/index.ts Outdated Show resolved Hide resolved
nmpz/index.ts
});
return [null, null];
});
if (!result) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAY] 特に意味がなさそう (直さなくてもいいけど)

@sh-mug sh-mug requested a review from hakatashi October 22, 2024 13:30
hakatashi
hakatashi approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@hakatashi hakatashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@sh-mug
Copy link
Member Author

sh-mug commented Oct 22, 2024

I'm not authorized to merge this pull request, so could you merge this?

@hakatashi
Copy link
Member

@sh-mug I added you to maintainer of this repo

@sh-mug
Copy link
Member Author

sh-mug commented Oct 22, 2024

Nice.

@sh-mug sh-mug merged commit eb00077 into master Oct 22, 2024
4 checks passed
@sh-mug sh-mug deleted the implement-nmpz branch October 22, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakatashi hakatashi hakatashi approved these changes

Assignees

@sh-mug sh-mug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh-mug @hakatashi